[m-rev.] for review: deep profiling.

[Simon Taylor]

On 07-May-2001, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> Zoltan Somogyi wrote:
> > Index: library/exception.m
> > ===================================================================
> > @@ -31,6 +31,9 @@
> >  :- func throw(T) = _.
> >  :- mode throw(in) = out is erroneous.
> >  
> > +:- pred throw_string(string).
> > +:- mode throw_string(in) is erroneous.
> > +
> >  % The following types are used by try/3 and try/5.
> >  
> >  :- type exception_result(T)
> > @@ -592,6 +595,11 @@
> >  
> >  %-----------------------------------------------------------------------------%
> >  
> > +:- pragma export(throw_string(in), "ML_throw_string").
> > +
> > +throw_string(Msg) :-
> > +	throw(Msg).
> 
> As the comment at the top of exception.m says, throwing exceptions
> across the C interface won't work.

This review comment wasn't dealt with. At the very least, `throw_string'
should not appear in the library documentation and there should be a
comment on the `:- pragma export' declaration warning that it shouldn't
be used in LLDS grades. It would be better to undo this change completely.

Simon.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------