[m-rev.] for review: constraint propagation [2]

[Fergus Henderson]

The relative diff looks fine.
There's just one point that bothers me a bit:

On 11-Aug-2001, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> compiler/det_analsysis.m:
> 	Disable reporting of errors and warnings when rerunning
> 	determinism analysis after constraint propagation.
...
> --- compiler/det_analysis.m	2001/04/07 14:04:34	1.150
> +++ compiler/det_analysis.m	2001/08/07 10:52:08
...
> -global_final_pass(ModuleInfo0, ProcList, Debug, ModuleInfo) -->
> +global_final_pass(ReportErrors, ModuleInfo0, ProcList, Debug, ModuleInfo) -->
>  	global_inference_single_pass(ProcList, Debug, ModuleInfo0, ModuleInfo1,
>  		[], Msgs, unchanged, _),
> -	det_report_and_handle_msgs(Msgs, ModuleInfo1, ModuleInfo2),
> -	global_checking_pass(ProcList, ModuleInfo2, ModuleInfo).
> +	( { ReportErrors = yes } ->
> +		det_report_and_handle_msgs(Msgs, ModuleInfo1, ModuleInfo2),
> +		global_checking_pass(ProcList, ModuleInfo2, ModuleInfo)
> +	;
> +		{ ModuleInfo = ModuleInfo1 }
> +	).

I understand why disabling reporting of warnings makes sense,
but it might be nice to have some sanity checking to ensure
that constraint propagation preserves determinism correctness.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------