[m-rev.] for review: improve the bindist for the .NET backend.

[Fergus Henderson]

On 06-Aug-2001, Tyson Dowd <trd at miscrit.be> wrote:
> bindist/bindist.Makefile.in:
...
> +ifeq ($(ILASM),ilasm)        
> +.PHONY: install_gac
> +install_gac: 
> +	-if test -d $(INSTALL_LIBDIR)/lib/ilc/ ; then 		\
> +		cd $(INSTALL_LIBDIR)/lib/ilc/i686-pc-cygwin/ ;	\
> +		gacutil -i mercury.dll ; 			\
> +	fi
> +else
> +.PHONY: install_gac
> +install_gac: 
> +endif

Instead of "cd ... ; gacutil ... "
it should be "cd ... && gacutil ...".

Instead of "i686-pc-cygwin", it should be $(FULLARCH),
and you should define

	FULLARCH = @FULLARCH@

somewhere at the top of that file.

You should omit the trailing "/" on the directory names, IMHO.

Why do you use "-if" rather than just "if"?
i.e. why do you want to ignore errors in this rule?
There should at least be a comment explaining that.

The test using `ifeq ($(ILASM),ilasm)' is a hack.  E.g. this may break
if/when we start using mono_ilasm or dotgnu_ilasm or whatever the Mono
and/or DotGNU projects decide to call their ilasm clones.
It would be better to test for e.g. `ifneq ("$(strip $(ILASM))","")'.
Or even better would be to test for `gacutil' in aclocal.m4,
and then use `ifneq ("$(strip $(GACUTIL))","")'.

Otherwise this looks OK.

In the long term it would be nice to support installing more than
one IL-related grade, e.g. both `il' and `ilc'.  But that should be a
separate change...

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------