[m-rev.] for review: fix misleading io__report_stats

Zoltan Somogyi zs at cs.mu.OZ.AU
Mon Apr 30 14:05:33 AEST 2001


On 26-Apr-2001, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> > runtime/mercury_wrapper.[ch]:
> > 	Add a global variable that records the size of the zones allocated
> > 	via Boehm gc since the last call to io__report_stats.
> > 
> > runtime/mercury_memory_zones.c:
> > 	Increment this global variable as appropriate.
> > 
> > library/benchmarking.m:
> > 	Subtract the global variable from the value reported for heap cell
> > 	allocations, then zero it to prevent double counting.
> 
> This fix doesn't work, I'm pretty sure.  E.g. it will do the wrong thing for
> 
> 	main -->
> 		io__report_stats,
> 		io__report_stats.
> 
> and for
> 
> 	main -->
> 		gc__garbage_collect,
> 		io__report_stats.

Why? What wrong thing do you think it will do?

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list