[m-rev.] diff: fix bugs with existential types & secondary tags

[Zoltan Somogyi]

On 29-Apr-2001, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> @@ -143,8 +146,13 @@
>  **
>  **                  for (i = 0; i < arity; i++) {
>  **                      if (MR_arg_type_may_contain_var(functor_desc, i)) {
> +**                          MR_Word *parent_data = (MR_Word *) new_data;
> +**			    if (have_sectag) {
> +**				// skip past the secondary tag
> +**				parent_data++;
> +**			    }

Instead of defining parent_data here, you should have defined it here:

> +**                  if (!have_sectag) {
>  **                      sectag = 0;
>  **                  } else {
>  **                      sectag = data_value[0];

since that is where decisions that depend on the presence or absence of
secondary tags are made.

Also, you inserted a good number of tabs into this file, which has four-space
indentation. Please remove them, e.g. by running "detab".

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------