[m-rev.] for review: install_hdrs bug fix

[Fergus Henderson]

On 03-Apr-2001, Peter Ross <peter.ross at miscrit.be> wrote:
> Not sure about the asm target.  Fergus?

I think there are existing problems with `mmake install' and header files
for `--target asm'.  Your patch won't make it any worse ;-)

> Branches: main, release
> 
> compiler/modules.m:
>     We only need to generate a body for the install_hdrs target if we
>     have been generating high-level C code.
>
> Index: compiler/modules.m
> ===================================================================
> RCS file: /home/mercury1/repository/mercury/compiler/modules.m,v
> retrieving revision 1.156
> diff -u -r1.156 modules.m
> --- compiler/modules.m	2001/04/03 03:20:07	1.156
> +++ compiler/modules.m	2001/04/03 10:30:31
> @@ -3061,7 +3061,8 @@
>  	module_name_to_lib_file_name("lib", ModuleName, ".install_hdrs", no,
>  				LibInstallHdrsTargetName),
>  	globals__io_lookup_bool_option(highlevel_code, HighLevelCode),
> -	( { HighLevelCode = yes } ->
> +	globals__io_get_target(Target),
> +	( { HighLevelCode = yes, ( Target = c ; Target = asm ) } ->
>  		%
>  		% XXX  Note that we install the header files in two places:
>  		% in the `inc' directory, so that the C compiler will find

The comment in the else case of that if-then-else needs updating.
But apart from that, this change looks good -- thanks.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
                                    |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------