[m-dev.] call for volunteers: get_environment_var_map

[Julien Fischer]

On Thu, 19 Aug 2021, Zoltan Somogyi wrote:

> On Thu, 19 Aug 2021 00:14:10 +1000 (AEST), Julien Fischer <jfischer at opturion.com> wrote:
> > Ideally, io.m should be broken up, but certainly not before the next
> > release.
> 
> Agreed.
> 
> > >
> > > - adding this get_environment predicate to a new library module, named
> > >   probably env.m or environment.m,
> > 
> > I think environment.m.  Should that be a top-level module in the library
> > or a submodule of the io module?
> 
> I don't think we should decide that for environment.m alone. We should
> decide along what lines we want to break up io.m, and use the nature
> of fragments to help answer that question.

Absolutely.

> > > - moving the existing io.get_environment_var predicate to the
> > >  new module, leaving a forwarding predicate behind, and
> > >
> > > - adding an "obsolete in favour of" pragma for that forwarding predicate.
> > 
> > I'll do so in the next couple of days.
> 
> Thank you.
> 
> > I have committed the diff below which implements get_envrionment_var_map
> > for C# and Java.  I suspect the C implementation is broken on macOS and
> > MinGW(?) (at least if the comments in the io module regarding the
> > environ global are up-to-date).
> 
> I am afraid you are right. Insert reference to the xkcd cartoon about
> 14 standards :-(

It's definitely broken on macOS; I'll commit a fix shortly.
(MinGW is probably alright because the point of difference there
is where environ is declared and the io module already handles that
correctly.)

Julien.