[m-dev.] question about infinite recursion warnings

[Zoltan Somogyi]

On Tue, 23 Apr 2019 01:26:01 +0000 (UTC), Julien Fischer <jfischer at opturion.com> wrote:

> 
> 
> On Sat, 20 Apr 2019, Zoltan Somogyi wrote:
> 
> > My question is: should I enable the new warning, either with
> > or without this extra proviso, anyway? We could avoid the problem
> > with --halt-at-warn by disabling infinite recursion warnings
> > either module-wide (in Mercury.options), or just for the calls
> > involved using the disable_warnings scope. The latter would
> > require bootstrapping the change to the scope.
> >
> > Basically, my question boils down to: which is more annoying?
> > Not getting an infinite recursion warning when you should,
> > in situations resembling the one above, or getting one when
> > you shouldn't?
> 
> I agree with Peter here, warning about probable (as opposed to definite)
> infinite recursion should be opt-in by default, so you should add a
> new option that controls whether the extra heuristics are enabled.
> (I have no objection to enabling the new option for the Mercury system
> itself.)

The attached diff adds the proposed new option. I welcome opinions
about its name. The rest of the diff is boring.

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.ir
Type: application/octet-stream
Size: 1176 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/developers/attachments/20190424/c22bfb53/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.ir
Type: application/octet-stream
Size: 14563 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/developers/attachments/20190424/c22bfb53/attachment-0001.obj>