[m-dev.] diff: GCC back-end: fix Mmake bug with `.pic_s' files

[Fergus Henderson]

On 24-Jan-2001, Tyson Dowd <trd at cs.mu.OZ.AU> wrote:
> On 24-Jan-2001, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> > Estimated hours taken: 0.5
> > 
> > Fix a bug where the Mmake rule for making `.pic_s' files didn't work,
> > because it was passing $(CFLAGS_FOR_PIC), i.e. `-fpic -DPIC',
> > to the GCC back-end, but the GCC back-end didn't understand `-DPIC'.
> > (The GCC *driver* understands `-D', as does the GCC C front-end,
> > but the back-end doesn't.)
> > 
> > scripts/Mmake.vars.in:
> > 	Define new variable GCCFLAGS_FOR_PIC, and set it to `-fpic'.
> > 
> > scripts/Mmake.rules:
> > 	In the rule for making `.pic_s' files, use $(GCCFLAGS_FOR_PIC)
> > 	instead of $(CFLAGS_FOR_PIC).
> > 
> > XXX remember to check that this diff includes all
> >     the relevant files that have been changed!
> 
> The change looks fine.
> 
> I assume the XXX is your system for making sure you are careful about
> including the relevant files.

Yes.  But the idea is that I'm supposed to delete the XXX before posting.
If the XXX shows up in any diff that I post, it is a sign that I
probably posted it in too much of a hurry!  That was indeed the
case for this diff, because further testing showed that it only
solved part of the problem.  I'm working on a fix for the remaining
problems.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
                                    |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------