[m-dev.] for review: Java runtime system (Part I)

[Fergus Henderson]

On 22-Feb-2001, Julien Fischer <juliensf at students.cs.mu.oz.au> wrote:
> 
> Classes used by the Java backend, particularly in the implementation
> of RTTI.  
> 
> java/Compare.java:
> java/DuExistInfo.java:
> java/DuExistLocn.java:
> java/DuFunctorDesc.java:
> java/DuPtagLayout.java:
> java/EnumFunctorDesc.java:
> java/JavaInternal.java:
> java/NotagFunctorDesc.java:
> java/ProcAddr.java:
> java/PseudoTypeInfo.java:
> java/Sectag_Locn.java:
> java/TypeCtorInfo_Struct.java
> java/TypeCtorRep.java:
> java/TypeFunctors.java:
> java/TypeLayout.java:
> java/Unify.java:
> java/UnreachableDefault.java:
> 	New files.

That looks fine.  Personally I would make the log message a little
bin more descriptive, e.g. splitting it up a little:

java/Compare.java:
java/Unify.java:
	New files.  Java classes for implementation the builtin unify
	and compare predicates.

java/JavaInternal.java:
	New file.  Java class for ...

java/DuExistInfo.java:
java/DuExistLocn.java:
java/DuFunctorDesc.java:
java/DuPtagLayout.java:
java/EnumFunctorDesc.java:
java/NotagFunctorDesc.java:
java/ProcAddr.java:
java/PseudoTypeInfo.java:
java/Sectag_Locn.java:
java/TypeCtorInfo_Struct.java
java/TypeCtorRep.java:
java/TypeFunctors.java:
java/TypeLayout.java:
	New files.  Java classes for implementing Mercury RTTI.

java/UnreachableDefault.java:
	New file.  ...

Also you should document in runtime/mercury_type_info.h that these
files may need to be changed if the RTTI representation changes.

Otherwise I'm happy with it.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
                                    |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------