[m-dev.] diff: fix for gcc 2.7.2.3

Fergus Henderson fjh at cs.mu.OZ.AU
Wed Feb 21 19:01:15 AEDT 2001


On 21-Feb-2001, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> On 21-Feb-2001, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> > configure.in:
> > 	Don't pass `-fno-gcse' for gcc versions < 2.8, since some
> > 	of them (e.g. gcc 2.7.2.3) complain about that option.
> > 
> > Index: configure.in
> > ===================================================================
> > RCS file: /home/mercury1/repository/mercury/configure.in,v
> > retrieving revision 1.247
> > diff -u -u -r1.247 configure.in
> > --- configure.in	2001/02/08 16:48:31	1.247
> > +++ configure.in	2001/02/21 04:37:51
> > @@ -1481,7 +1481,7 @@
> >  LIBRARY_PATH_FOR_GOTOS=
> >  case $ac_cv_prog_gcc in yes)
> >      case "`$CC --version < /dev/null`" in
> > -	2.8*) CFLAGS_FOR_GOTOS="-fno-defer-pop -fno-function-cse" ;;
> > +	2.[0-8]*) CFLAGS_FOR_GOTOS="-fno-defer-pop -fno-function-cse" ;;
> 
> This is inconsistent with the log message.  It looks like an off-by-one error
> since it doesn't pass -fno-gcse even to version 2.8.*.

I think you have misread either the log message or the diff.
The log message said don't pass `-fno-gcse' for gcc versions < 2.8.
We already didn't pass `-fno-gcse' for gcc version 2.8*.
My change only changed the behaviour for 2.[0-7]*.
You need to look at the next line of the diff:

        *)    CFLAGS_FOR_GOTOS="-fno-defer-pop -fno-function-cse -fno-gcse" ;;

This is the default case -- it passes `-fno-gcse'.  Previously 2.7.*
fell into the default case, and so we passed -fno-gcse.  Unfortunately
2.7.2.3 rejects `-fno-gcse'.  With my change, we now do the same thing
for 2.7.* that we do for 2.8.*, which is to not pass `-fno-gcse'.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
                                    |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------



More information about the developers mailing list