[m-dev.] for review:

[Fergus Henderson]

On 12-Feb-2001, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> This is for both branches.
> 
> var_locn.m:
> 	Loosen a sanity check, to enable us to compile var.m in
> 	extras/trailed_update at -O3 without a compiler abort.
> 
> Index: compiler/var_locn.m
> ===================================================================
> RCS file: /home/mercury1/repository/mercury/compiler/var_locn.m,v
> retrieving revision 1.2
> diff -u -b -r1.2 var_locn.m
> --- compiler/var_locn.m	2000/09/19 03:05:16	1.2
> +++ compiler/var_locn.m	2001/02/09 06:16:13
> @@ -1464,8 +1464,10 @@
>  			var_locn__set_var_state_map(VarStateMap)
>  		)
>  	;
> -		{ require(unify(FirstTime, no),
> -			"var_locn__var_becomes_dead: premature deletion") }
> +		[]
> +		% With the current liveness pass, this can fail.
> +		% { require(unify(FirstTime, no),
> +		% 	"var_locn__var_becomes_dead: premature deletion") }
>  	).

It's probably worth marking that with an XXX,
and updating the comments for the var_becomes_dead procedure
(both the ones in the interface and the ones in the implemetation)
since your change makes those comments misleading now.

But otherwise this looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
                                    |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------