[m-dev.] for review: new_object size in words

[Fergus Henderson]

On 09-Feb-2001, Julien Fischer <juliensf at students.cs.mu.oz.au> wrote:
> On Thu, 8 Feb 2001, Fergus Henderson wrote:
> > Change the units for the size field in MLDS new_object
> > statements from bytes to words.
...
> s/Multiple/Multiply/

Done.

> > +++ compiler/mlds_to_gcc.m	2001/02/07 14:52:35
> > @@ -2839,28 +2839,10 @@
> 
> > -			% XXX something else
> > +			% XXX do we need to handle this case?
> > +			% I think it's needed for --high-level-data
> >  			error("unknown size in MLDS new_object")
> 
> It might be nice to be sure of that.  Otherwise it all looks fine.

You're right, but that is an existing issue, not one introduced in
this change.  All I did in this change is to modify the comment.
So I've gone ahead and committed this change.

I'm pretty sure that code to handle that case is needed only for
`--high-level-data'.  At any rate the compiler bootstraps using
`--target asm' without calling error/1 there.  So I'll leave
addressing that one until we try to support `--high-level-data'
for `--target asm'.  Note that `--high-level-data' is not properly
supported for `--target c' yet, which is a higher priority.

The two main problems with `--high-level-data for `--target c'
are (1) the generated `.h' files are different for `--high-level-data',
but currently we only install one copy of those header files;
and (2) the same issue with abstract equivalence types that
causes problems for the Java and IL ports.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
                                    |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------