[m-dev.] for review: Linux stack overflow fix.

[Fergus Henderson]

On 11-Sep-2000, Tyson Dowd <trd at cs.mu.OZ.AU> wrote:
> Fergus made a few suggestions, which are reflected in this incremental
> diff.

With those changes, this diff looks good... just one small comment:

> diff -u runtime/mercury_memory_handlers.c runtime/mercury_memory_handlers.c
> --- runtime/mercury_memory_handlers.c
> +++ runtime/mercury_memory_handlers.c
> @@ -946,7 +946,7 @@
>  #ifndef	MR_LOWLEVEL_DEBUG
>  
>  	const char *msg =
> -		"You can get a stack dump by recompiling in a debugging grade.\n";
> +		"This may have been caused by a stack overflow, due to unbounded recursion.\n";

I suggest s/due to/which can be caused by/

(There are other possible reasons for stack overflow,
e.g. bounded recursion where the bound is greater than the stack size.)

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------