[m-dev.] diff: mercury_timing.c

Fergus Henderson fjh at cs.mu.OZ.AU
Mon Sep 4 13:11:27 AEDT 2000


On 01-Sep-2000, Peter Ross <peter.ross at miscrit.be> wrote:
> +#elif HAVE_SYS_TIMES_H
> +  #ifdef MR_CLOCK_TICKS_PER_SECOND

For consistency, that should probably be

	#elif defined(HAVE_SYS_TIMES_H)

or

	#elif defined HAVE_SYS_TIMES_H

rather than

	#elif HAVE_SYS_TIMES_H

so that you're effectively using a #ifdef test rather than a #if test.

Also, since the #else code for these two is the same, I think it would
be clearer if you combined that into a single test:

	#elif defined(HAVE_SYS_TIMES_H) && defined(MR_CLOCK_TICKS_PER_SECOND)

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------



More information about the developers mailing list