[m-dev.] for review: MR_TRACE_USE_HP

[Fergus Henderson]

On 16-Oct-2000, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> 
> trace/mercury_trace_browse.c:
> trace/mercury_trace_help.c:
> 	Add MR_TRACE_USE_HP macros around calls to MR_make_permanent, since
> 	on SPARCs this may be necessary to really update MR_hp.

After we talked about this, I realized that those calls to
MR_TRACE_USE_HP() are not needed.  The MR_make_permanent() macro does
not use MR_hp directly, it just calls a C function which uses MR_hp.
Note that calling the effect of calling restore_transient_registers()
is undone any time you call a C function, so doing it outside the
function doesn't help.  And in this case that C function itself already
does the restore_transient_registers() and save_transient_registers()
needed.  So I think you should undo this change.

(Sorry for the incorrect over-the-shoulder review -- for these kinds of
things its quite difficult to review them in "real time".)

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------