[m-dev.] for review: .agc fixes needed to compile runtime

Fergus Henderson fjh at cs.mu.OZ.AU
Mon Nov 6 19:28:04 AEDT 2000


On 06-Nov-2000, Tyson Dowd <trd at cs.mu.OZ.AU> wrote:
> Hi,
> 
> This is for Zoltan -- much of this code is prototype code, but it should
> fix the immediate problem that the .agc grades don't compile.
> Then Zoltan can compile his fix for the code generator and .agc grades,
> and I then keep debugging the prototype code.
> 
> ===================================================================
> 
> 
> Estimated hours taken: 8
> 
> Updates to the accurage garbage collector (including fixes to get it to
> compile and also to use the MR_Long_Lval and MR_Short_Lval code).
> A prototype of non-det stack tracing is also in this code.

That code looks fine, except for one thing:

> runtime/mercury_layout_util.c:
> runtime/mercury_layout_util.h:
> 	Fix a type -- MR_TypeInfo instead of MR_Word.

> --- runtime/mercury_layout_util.c	2000/10/16 01:33:58	1.19
> +++ runtime/mercury_layout_util.c	2000/11/06 07:23:55
> @@ -399,7 +399,7 @@
>  }
>  
>  void
> -MR_write_variable(MR_Word type_info, MR_Word value)
> +MR_write_variable(MR_TypeInfo type_info, MR_Word value)
>  {
>  	MR_Word	stdout_stream;

        (*MR_io_stdout_stream)(&stdout_stream);
	(*MR_io_print_to_stream)(type_info, stdout_stream, value);

You need a cast from MR_TypeInfo to Word here, since the type of the
first argument to MR_io_print_to_stream is Word rather than MR_TypeInfo.

You should recompile everything and look at the warning messages.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
                                    |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------



More information about the developers mailing list