[m-dev.] for review: specializing comparisons

[Fergus Henderson]

On 06-Nov-2000, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> +++ compiler/handle_options.m	2000/11/03 08:51:20
> @@ -320,6 +320,16 @@
>  
>  	% --split-c-files implies --procs-per-c-function 1
>  	option_implies(split_c_files, procs_per_c_function, int(1)),
> +
> +	% make_hlds contains an optimization which requires the value of the
> +	% compare_specialization option to accurately specify the max number
> +	% of constructors in a type whose comparison procedure is specialized
> +	% and which therefore don't need index functions.
> +	globals__io_lookup_int_option(compare_specialization, CompareSpec0),
> +	{ int__min(unify_proc__max_exploited_compare_spec_value,
> +		CompareSpec0, CompareSpec) },
> +	globals__io_set_option(compare_specialization, int(CompareSpec)),

Did you mean to use `int__max' rather than `int__min' here?
Won't that code always set the compare_specialization option to 3?

That explains why the benchmark results were mostly within estimated
measurement error ;-)
I think it must be time to redo all those benchmarks...

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
                                    |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------