[m-dev.] for review: expand implicit trees in the debugger

Fergus Henderson fjh at cs.mu.OZ.AU
Tue May 9 03:53:13 AEST 2000


I had a brief look at it.  I spotted a few places where
it doesn't conform to our layout guidelines, but apart
from that it looked OK.

On 02-Mar-2000, Mark Anthony BROWN <dougl at cs.mu.OZ.AU> wrote:
> +++ trace/mercury_trace_declarative.c	2000/03/01 23:51:25
> +	if (MR_edt_inside)
> +	{

The `{' should be on the same line as the `if'.

> +	}
> +	else
> +	{

Likewise that should be `} else {' on one line.

> +		if (event_info->MR_call_seqno == MR_edt_start_seqno)
> +		{

Likewise here.

> +			** The port must be either CALL or REDO;
> +			** we are (re)entering the topmost call.
> +			*/
> +			MR_edt_inside = TRUE;
> +		}
> +		else
> +		{

Likewise here.

> +++ trace/mercury_trace_internal.c	2000/03/01 23:51:46
> @@ -210,8 +210,7 @@
>  	}
>  
>  #ifdef	MR_USE_DECLARATIVE_DEBUGGER
> -	if (MR_trace_decl_mode == MR_TRACE_DECL_DEBUG
> -		|| MR_trace_decl_mode == MR_TRACE_DECL_DEBUG_TEST)
> +	if (MR_trace_decl_mode != MR_TRACE_INTERACTIVE)
>  	{

And here.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------



More information about the developers mailing list