[m-dev.] for review: refactor generation of builtins

[Fergus Henderson]

On 15-Mar-2000, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
>  
> > -		{ error("rl_exprn__maybe_llds_rval_to_rl_rval: invalid llds rval") }
> > +		{ error("rl_exprn__maybe_simple_expr_to_rl_rval: invalid llds rval") }
> 
> That should probably be changed to 
> 
> > +		{ error("rl_exprn__maybe_simple_expr_to_rl_rval: invalid simple_expr") }

Done.

> > +rl_exprn__simple_expr_to_rl_rval(unary(_UnOp, _Expr), _Code) -->
> > +	% XXX is this correct?
> > +	{ fail }.
> 
> It is. There should probably be a comment:
> 
> 	% None of the MLDS/LLDS unary builtins are implemented in Aditi.
> 	% The only one which is returned by builtin_ops__translate_builtin
> 	% is `bitwise_complement', for which there is no corresponding
> 	% bytecode in Aditi-RL.

I've replaced the XXX comment with the one immediately above.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------