[m-dev.] for review: semantic eval_method tests

Fergus Henderson fjh at cs.mu.OZ.AU
Thu Mar 9 18:58:38 AEDT 2000


On 09-Mar-2000, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> Make a separate enquery function for each possible semantic test on
> eval_methods. The answers are the same now, but will be different when
> tabled I/O is implemented.
> 
> compiler/hlds_pred.m:
> 	Make a separate enquery function for each possible semantic test on
> 	eval_methods.
> 
> compiler/code_gen.m:
> compiler/ml_code_gen.m:
> compiler/make_hlds.m:
> compiler/modes.m:
> compiler/table_gen.m:
> 	Use the new enquery functions.

That looks good, thanks.

s/enquery/enquiry/g
(or just s/enquery //g)

> Index: modes.m
> ===================================================================
> RCS file: /home/mercury1/repository/mercury/compiler/modes.m,v
> retrieving revision 1.239
> diff -u -b -r1.239 modes.m
> --- modes.m	2000/02/24 18:36:35	1.239
> +++ modes.m	2000/03/09 06:03:23
> @@ -2183,7 +2181,7 @@
>  			( { VerboseErrors = yes } ->
>  				io__write_string(
>  "	Tabling of predicates/functions with partially instantiated modes
> -	is not currently implemented.\n")
> +is not currently implemented.\n")

This modification is not mentioned in the log message, does not seem to be
related to the other changes in this diff, and in any case looks wrong.
The whole error message is supposed to be intended one tab, not just the first
line.

> @@ -2207,17 +2205,14 @@
>  			( { VerboseErrors = yes } ->
>  				io__write_string(
>  "	Tabling of predicates/functions with unique modes is not allowed
> -	as this would lead to a copying of the unique arguments which 
> -	would result in them no longer being unique.\n")
> +as this would lead to a copying of the unique arguments which 
> +would result in them no longer being unique.\n")

Likewise here.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------



More information about the developers mailing list