[m-dev.] for review: polymorphic ground insts

[Fergus Henderson]

On 17-Mar-2000, David Overton <dmo at ender.cs.mu.oz.au> wrote:
> 
> Here is one more relative diff.  Some of the test cases fail due to
> `type_util__get_cons_id_arg_types' not supporting existentially typed
> cons_ids.  I have disabled these test cases.  Is that the best thing
> to do for now?

Ah, no, that would not be a good thing to do.

Currently type_util__get_cons_id_arg_types does not support existentially
typed cons_ids, but it is not called from anywhere that needs to be able to
handle existential typed cons_ids, so that is only a minor problem.  Making
your change, which adds additional calls to get_cons_id_arg_types in crucial
places, and then simply disabling those test cases would exacerbate that minor
problem into a major problem -- specifically, it would break our support for
existential types.

I think the best thing to do is to fix it so that those test cases pass,
for example by changing your code so that it does not call
type_util__get_cons_id_arg_types.

You may be able to use get_cons_id_arg_types_adding_existq_tvars
from post_typecheck.m.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------