[m-dev.] for review: fix pragma import of polymorphic preds

[Peter Ross]

On Thu, Jul 20, 2000 at 08:37:08PM +1000, Fergus Henderson wrote:
> On 20-Jul-2000, Peter Ross <peter.ross at miscrit.be> wrote:
> > Index: compiler/polymorphism.m
> > @@ -988,6 +1012,26 @@
> >  polymorphism__process_goal_expr(bi_implication(_, _), _, _) -->
> >  	% these should have been expanded out by now
> >  	{ error("polymorphism__process_goal_expr: unexpected bi_implication") }.
> > +
> > +
> > +	% type_info_vars construcs a comma seperated list of variables.
> > +	% It places an & at the start of the variable name if variable
> > +	% is an output variable.
> > +:- func type_info_vars(module_info, list(maybe(pair(string, mode)))) = string.
> 
> s/construcs/constructs/
> s/seperated/separated/
> s/&/`&'/
> s/if variable/if the variable/
> 
> Is the list comma terminated too?  If so, the comment should say that.
> 
Yes it is.

> Should it be?  What about the case where there are no variables in the
> argument list other than the type_info variables?
> I think your code won't handle that case correctly.

No it shouldn't for the reasons you point out below.

Pete
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------