[m-dev.] for review: EDCGs - diff part 1

Fergus Henderson fjh at cs.mu.OZ.AU
Thu Jan 27 23:04:45 AEDT 2000

On 24-Dec-1999, Peter Nicholas MALKIN <pnmalk at cat.cs.mu.OZ.AU> wrote:
> Detailed Desciption of Change:

It would help for the log message to start with a one or two line summary
of the changes.

> Index: compiler/edcg.m
> +% Copyright (C) 1993-1999 The University of Melbourne.

Probably the copyright date should be 1999-2000.

> +:- module edcg.
> +
> +:- interface.
> +:- import_module string, list, term, bool.
> +:- import_module hlds_module, hlds_pred, hlds_goal.
> +:- import_module prog_data, prog_io_util.
> +:- import_module std_util.
> +
> +:- implementation.
> +:- import_module prog_util, prog_out, prog_io, prog_io_goal, mercury_to_mercury.
> +:- import_module io, map, set, int, assoc_list, require, varset.
> +:- import_module hlds_data, hlds_out, make_hlds, error_util.
> +:- interface.

Please don't use multiple `:- interface' declarations in a single
module without very good reason.

> +:- type hidden_arg    ==     sym_name.
> +:- type hidden_arg_and_vars == list(pair(hidden_arg, prog_vars)).

You should perhaps use assoc_list here rather than list(pair(...)),
particularly if list has the invariant that the keys (the
hidden_args) are all supposed to be distinct.

[... to be continued, when you post the latest version of this diff.]

Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at        |     -- the last words of T. S. Garp.
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au

More information about the developers mailing list