[m-dev.] For review: More clpr updates

[Fergus Henderson]

On 03-Feb-2000, Warwick Harvey <wharvey at cs.monash.edu.au> wrote:
> Part of this change includes by default installing a standalone version of 
> CLP(R) if the user installs the CLP(R) libraries.  I find this useful, but 
> maybe it's not appropriate?

I don't think it is appropriate.
By all means add a target to do that, and document it
in the README file, but I don't think it should be
part of the normal "install" target.

> -SUBDIR_MMAKE = mmake $(MMAKEFLAGS) \
> -		GRADE=$(GRADE) \
> -		EXTRA_MCFLAGS="$(EXTRA_MCFLAGS)" \
> -		EXTRA_CFLAGS="$(EXTRA_CFLAGS)"
...
> +.PHONY: depend_samples
>  depend_samples:
> -	cd samples && $(SUBDIR_MMAKE) depend
> +	cd samples && $(MMAKE) $(MMAKEFLAGS) depend

I think it would be best to keep $(SUBDIR_MMAKE),
even if that is defined as just $(MMAKE) $(MMAKEFLAGS).

> Index: clpr/Mmakefile
...
> +MAKE = gmake

That is wrong, I think; AFAIK there is no guarantee that the system
will have a program called `gmake' on it.

> +# This should be made more general
> +clpr_script: clpr_script.in
> +	sed -e "s, at LIBDIR@,$(INSTALL_LIBDIR),g" \
> +		-e "s, at FULLARCH@,$(FULLARCH),g" < $< > $@
> +	chmod +x $@

`chmod +x' is not portable, I think; on some systems
it means `chmod u+x' and on others it means `chmod a+x'.
Probably you want `chmod a+x' here.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------