[m-dev.] for review: clarifying cse_detection.m

Fergus Henderson fjh at cs.mu.OZ.AU
Mon Dec 4 17:39:50 AEDT 2000


On 04-Dec-2000, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> For review by Fergus or Simon.
> 
> compiler/cse_detection.m:
> 	Make the code for finding common subexpressions significantly clearer
> 	by using a single type for each possible state of the search, instead
> 	of dividing the state between a maybe and a bool.
> 
> 	Instead of passing around several data structures separately,
> 	wrap them up in a cse_info data structure.
> 
> 	Extend the cse_info data structure with fields that will be required
> 	to fix common subexpression elimination over existentially typed
> 	functors.
> 
> 	Switch to using predmode declarations when appropriate.
> 
> compiler/switch_detection.m:
> 	Remove some redundancy from a comment.

That looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
                                    |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------



More information about the developers mailing list