[m-dev.] for review: install all needed grades before testing

[Fergus Henderson]

On 23-Aug-2000, Mark Anthony BROWN <dougl at cs.mu.OZ.AU> wrote:
> Fergus Henderson writes:
> > On 22-Aug-2000, Mark Anthony BROWN <dougl at cs.mu.OZ.AU> wrote:
> > > The nightly tests on hydra have been failing in the debugger/declarative
> > > directory, with grade asm_fast.gc.prof.  The problem is that these tests
> > > are linked with an older version of the browser library, since the new
> > > library is not installed in that grade until after the tests are run.
> > 
> > That diagnosis doesn't sound right to me, because the test_mercury script
> > installs the library grades *before* running the tests.
> 
> That's what is meant to happen, but the set of library grades installed
> at that point doesn't include all the grades that are tested.  On hydra
> asm_fast.gc.prof is not installed then, but is tested later.  (I checked
> the tests log on hydra to verify this.)

You're right that on hydra asm_fast.gc.prof is not installed before being
tested.  But you were wrong in assuming that it would be installed after
being tested.  In fact since August 18th, asm_fast.gc.prof is not
being installed on hydra at all.  The reason is that the autoconf
test is failing:

	checking whether we can support profiling on this system... no

The following diff, which I've committed, should fix the problem.

----------

Estimated hours taken: 0.5

configure.in:
	Fix a cut-and-paste error in Peter Ross's previous change:
	it was defining MR_INT_LEAST16_TYPE twice.

Workspace: /home/pgrad/fjh/ws/hg
Index: configure.in
===================================================================
RCS file: /home/mercury1/repository/mercury/configure.in,v
retrieving revision 1.218
diff -u -d -r1.218 configure.in
--- configure.in	2000/08/17 09:58:04	1.218
+++ configure.in	2000/08/23 22:44:29
@@ -837,9 +837,6 @@
 MR_WORD_TYPE=$mercury_cv_word_type
 AC_SUBST(MR_WORD_TYPE)
 
-AC_DEFINE_UNQUOTED(MR_INT_LEAST16_TYPE, $mercury_cv_int_least16_type)
-MR_INT_LEAST16_TYPE=$mercury_cv_int_least16_type
-
 if test "$mercury_cv_word_type" = int; then
 	AC_DEFINE_UNQUOTED(MR_INTEGER_LENGTH_MODIFIER, "")
 elif test "$mercury_cv_word_type" = long; then

> Ok, how about something like the following?  It's a bit of a double
> maintenance problem, so I've added a comment.
> 
> 
> Estimated hours taken: 1.5
> 
> tools/test_mercury:
> 	Install the libraries in grade asm_fast.gc.prof on hydra, before
> 	the tests are run in that grade.
> 
> Index: tools/test_mercury
> ===================================================================
> RCS file: /home/mercury1/repository/mercury/tools/test_mercury,v
> retrieving revision 1.116
> diff -u -r1.116 test_mercury
> --- tools/test_mercury	2000/08/16 08:14:58	1.116
> +++ tools/test_mercury	2000/08/22 15:22:50
> @@ -320,10 +320,13 @@
>  	|| status=1
>  
>  	# If you want to add extra grades to install on specific hosts,
> -	# do it here.
> +	# do it here.  Any grade which is tested later, but which is not
> +	# installed above, should be installed here.
>      case $HOST in
>      	hg)	mmake install_grades LIBGRADES="asm_fast.par.gc" || status=1
>  		;;
> +	hydra)	mmake install_grades LIBGRADES="asm_fast.gc.prof" || status=1
> +		;;
>  	*)
>  		;;
>      esac
> @@ -430,6 +433,9 @@
>  
>  #MERCURY_COMPILER=$DIR/mercury/stage2/compiler/mercury_compile
>  #export MERCURY_COMPILER
> +
> +# Any grade here that is not installed by default needs to be explicitly
> +# installed above, before the tests are run.
>  case $HOST in
>  	mundook|murlibobo)
>  		GRADES="none none.gc
> 
> 
> Cheers,
> Mark.
> 
> --------------------------------------------------------------------------
> mercury-developers mailing list
> Post messages to:       mercury-developers at cs.mu.oz.au
> Administrative Queries: owner-mercury-developers at cs.mu.oz.au
> Subscriptions:          mercury-developers-request at cs.mu.oz.au
> --------------------------------------------------------------------------

The comment changes in that diff are good.
The change to add asm_fast.gc.prof on hydra should not be committed,
but it would be useful to commit the comment changes.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------