[m-dev.] for review: install all needed grades before testing

[Fergus Henderson]

On 22-Aug-2000, Mark Anthony BROWN <dougl at cs.mu.OZ.AU> wrote:
> The nightly tests on hydra have been failing in the debugger/declarative
> directory, with grade asm_fast.gc.prof.  The problem is that these tests
> are linked with an older version of the browser library, since the new
> library is not installed in that grade until after the tests are run.

That diagnosis doesn't sound right to me, because the test_mercury script
installs the library grades *before* running the tests.  As it says
in the comments in that script:

	# Tests can fail if linked against an old library, and compiled
	# with a new compiler, so we'll install the libraries first (so
	# long as we bootcheck), then run all the tests in all the grades.

So, could you explain why you think the tests are linked with an older
version of the browser library?

There is also a problem with the code in your diff:

> @@ -315,19 +363,10 @@
>      # again, look back in the CVS archives for version 1.114 to see
>      # the necessary code.
>  
> -    mmake install MMAKEFLAGS=$PARALLEL || status=1
> +    mmake install LIBGRADES=$GRADES MMAKEFLAGS=$PARALLEL || status=1

This will install not just in $GRADES but also in the default grade.
If the default grade is in $GRADES, as will most likely be the case,
then it will install in the default grade twice.

Also, this change would mean that the grades that don't get tested
(e.g. because testing them would take too long) also don't get
installed.  I don't think that is desirable.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------