[m-dev.] For review: implementation of collect for Opium-M

[Fergus Henderson]

On 29-Oct-1999, Erwan Jahier <Erwan.Jahier at irisa.fr> wrote:
> Index: 0.4/dl.m
> --- 0.4/dl.m Thu, 28 Oct 1999 12:57:51 +0200 jahier (collect/2_dl.m 1.1 640)
> +++ 0.4(w)/dl.m Fri, 29 Oct 1999 14:29:42 +0200 jahier (collect/2_dl.m 1.1 640)
> @@ -227,6 +227,7 @@
>  	make_aligned_string_copy(ErrorMsg, msg);
>  }").
>  
> +:- pragma export(close(in, out, di, uo), "ML_dl__close").

I suggest that be named `ML_DL_close', for consistency with
the naming convention used elsewhere.

collect.in:
> +
> +:- type collect_result --->
> +       collected(collected_type).

A comment here explaining what this type is for would help.
I presume this is the type of the debugger response?
If so, you should document the existence of this response type with
the `debugger_response' type in browser/debugger_interface.m.

The rest of the relative diff looks OK, but I'd like to look at full
diff again -- could you please send an updated version of the full diff?

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------