[m-dev.] for review: add type_ctor_reps for user-defined equality

[Zoltan Somogyi]

> This change uses the version number in the type_ctor_info to allow 
> Easy Bootstrapping(TM).

Three comments. First, you need to wait until the version number change
has been installed on all systems before committing this.

Second, the comment

> +** constructor.  For the cases of MR_TYPE_CTOR_REP_DU and
> +** MR_TYPE_CTOR_REP_DU_USEREQthe exact representation depends on the tag
> +** value -- lookup the tag value in type_ctor_layout to find out this
> +** information.

has some wordsrunningintoeachother.

> +typedef enum MR_OldTypeCtorRepresentation {
> +	MR_OLD_TYPECTOR_REP_ENUM,
> +	MR_OLD_TYPECTOR_REP_DU,
> +	MR_OLD_TYPECTOR_REP_NOTAG,
> +	MR_OLD_TYPECTOR_REP_EQUIV,
> +	MR_OLD_TYPECTOR_REP_EQUIV_VAR,
> +	MR_OLD_TYPECTOR_REP_INT,
> +	MR_OLD_TYPECTOR_REP_CHAR,
> +	MR_OLD_TYPECTOR_REP_FLOAT,
> +	MR_OLD_TYPECTOR_REP_STRING,
> +	MR_OLD_TYPECTOR_REP_PRED,
> +	MR_OLD_TYPECTOR_REP_UNIV,
> +	MR_OLD_TYPECTOR_REP_VOID,
> +	MR_OLD_TYPECTOR_REP_C_POINTER,
> +	MR_OLD_TYPECTOR_REP_TYPEINFO,
> +	MR_OLD_TYPECTOR_REP_TYPECLASSINFO,
> +	MR_OLD_TYPECTOR_REP_ARRAY,
> +	MR_OLD_TYPECTOR_REP_SUCCIP,
> +	MR_OLD_TYPECTOR_REP_HP,
> +	MR_OLD_TYPECTOR_REP_CURFR,
> +	MR_OLD_TYPECTOR_REP_MAXFR,
> +	MR_OLD_TYPECTOR_REP_REDOFR,
> +	MR_OLD_TYPECTOR_REP_REDOIP,
> +	MR_OLD_TYPECTOR_REP_TRAIL_PTR,
> +	MR_OLD_TYPECTOR_REP_TICKET,
> +	/*
> +	** MR_OLD_TYPECTOR_REP_UNKNOWN should remain the last alternative;
> +	** MR_CTOR_REP_STATS depends on this.
> +	*/
> +	MR_OLD_TYPECTOR_REP_UNKNOWN
> +} MR_OldTypeCtorRepresentation;

Third, I did not see any use of the new type in the diff. Is it needed?

Apart from that, the change looks fine.

Zoltan.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------