[m-dev.] for review: a "delete" command for the debugger

Fergus Henderson fjh at cs.mu.OZ.AU
Thu Oct 7 16:46:27 AEST 1999


On 07-Oct-1999, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> 
> Add a new command to the debugger for deleting (as opposed to disabling)
> breakpoints.
...
> -			if (MR_spy_point_next == 0) {
> -				fprintf(MR_mdb_out,
> -					"There are no break points yet.\n");
> +			if (count == 0) {
> +				fprintf(MR_mdb_err, "No breakpoints exist.\n");

I think "There are no break points" is clearer than "No breakpoints exist".

(The same code occurs in a couple of different places in
mercury_trace_internal.c.)

> +					"Break point #%d does not exist.\n",
...
> +				fprintf(MR_mdb_err, "No breakpoints exist.\n");

The usage of "breakpoint" vs "break point" here is inconsistent.
(I prefer the latter.)

Apart from that, this change looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------



More information about the developers mailing list