[m-dev.] for review: ANSI C fixes for none.x grades

[Fergus Henderson]

On 25-Nov-1999, Peter Ross <petdr at cs.mu.OZ.AU> wrote:
> +++ mercury_faultaddr.h	1999/11/23 03:24:31
> @@ -20,7 +20,7 @@
>  #if defined(__i386__)
>  
>    #define MR_GET_FAULT_ADDR(sc) \
> -	((void *)(((struct sigcontext_struct)(sc)).cr2))
> +	((void *)(((sc)).cr2))

There's a couple of unnecessary sets of parentheses there.
In particular `((sc))' should be just `(sc)'.
Also our convention is to use a space after the type cast.

So I suggest you write that as either
	((void *) ((sc).cr2))
or
	((void *) (sc).cr2)

Apart from that, and the comments in my earlier mail,
this change looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------