[m-dev.] Add an bool argument to filter

[Fergus Henderson]

On 03-Nov-1999, Erwan Jahier <Erwan.Jahier at irisa.fr> wrote:
> browser/debugger_interface.m:
> 	Define two news debugger responses `execution_continuing' and 
> 	`execution_terminated' that respectively tells the debugger that
> 	the execution continues or is terminated after the response to collect
> 	has been sent.
> 	
> browser/collect_lib.m:
> 	Update comments.
> 
> trace/mercury_trace_external.c:
> Opium-M/source/collect.in:
> Opium-M/source/collect.op:
> 	Add an new argument to filter that says saying whether we stop 
> 	collecting or not.
...
> +static void
> +MR_send_collect_result(void)
> +{
> +	Word	*close_result;	
> +
> +	(*send_collect_result_ptr)(
> +		MR_collecting_variable, 
> +		(Word) &MR_debugger_socket_out);
> +#if defined(HAVE_DLFCN_H) && defined(HAVE_DLCLOSE)
> +	MR_TRACE_CALL_MERCURY(
> +       		ML_CL_unlink_collect(collect_lib_maybe_handle));
> +#endif
> +}

I think `close_result' is an unused variable there.
Also I think the call to *send_collect_result_ptr should be
inside MR_TRACE_CALL_MERCURY().  Please be careful about that.
It would be a good idea for you to go through mercury_trace_external.c
and check every function call to see whether it needs to be
enclosed inside MR_TRACE_CALL_MERCURY().

Apart from that, this change looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------