[m-dev.] For review: implementation of collect for Opium-M

[Fergus Henderson]

On 02-Nov-1999, Erwan Jahier <Erwan.Jahier at irisa.fr> wrote:
> Index: trace/mercury_trace_external.c
..
> +static void	MR_get_object_file_name(Word debugger_request, 
> +			String *objet_file_name_ptr);

s/objet/object/

> +		case MR_collecting:
> +			/* 
> +			** XXX Add a another request that takes 
> +			** arguments into account. We need two kinds 
> +			** of request in order to not penalize the 
> +			** performance of collect in the cases where 
> +			** arguments are not used.
> +			**  
> +			** arguments = MR_make_var_list(layout, saved_regs);
> +			*/
> +			MR_COLLECT_filter(
> +				*filter_ptr, 
> +				seqno, 
> +				depth, 
> +				port,
> +				layout, 
> +				path);

You might as well write that function call on two lines rather than 7.

Apart from that, it looks fine this time, so if it works, please commit it.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------