[m-dev.] for review: removing --args simple

[Simon Taylor]

> For review by anyone.
> 
> Estimated hours taken: 4
> 
> Remove support for --args simple. We don't use it, we won't use it even for
> experiments, and it is unnecessary complication.

I've got a few comments.

> Index: compiler/magic.m
> ===================================================================
> RCS file: /home/mercury1/repository/mercury/compiler/magic.m,v
> retrieving revision 1.3
> diff -u -b -u -r1.3 magic.m
> --- magic.m	1999/04/28 01:18:36	1.3
> +++ magic.m	1999/05/28 08:54:36
> @@ -687,7 +687,7 @@
>  	{ varset__init(TVarSet) },
>  	{ hlds_pred__define_new_pred(Goal, CallGoal, HeadVars, ExtraArgs,
>  		InstMap, PredName, TVarSet, VarTypes, ClassContext, TVarMap,
> -		TCVarMap, VarSet, Markers, Owner,
> +		TCVarMap, VarSet, Markers, Owner, no,
>  		ModuleInfo1, ModuleInfo2, LocalPredProcId) },

I'd suggest adding a separate unification `HasAddressTaken = no', or adding
`:- type address_taken ---> address_taken ; address_not_taken'.
(There are more instances of this elsewhere).

> Index: library/benchmarking.m
> ===================================================================
> RCS file: /home/mercury1/repository/mercury/library/benchmarking.m,v
> retrieving revision 1.23
> diff -u -b -u -r1.23 benchmarking.m
> --- benchmarking.m	1999/05/26 04:13:53	1.23
> +++ benchmarking.m	1999/05/31 02:05:25

> @@ -680,8 +665,8 @@
>  	}
>  
>  	/* no more iterations */
> -	count_output = framevar(3);
> -	time_output = MR_get_user_cpu_miliseconds() - framevar(4);
> +	r1 = framevar(3);
> +	r2 = MR_get_user_cpu_miliseconds() - framevar(4);
>  	succeed_discard();

I think these changes (and similar changes throughout the library
and runtime) make the code less readable.

Simon.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------