[m-dev.] for review: update alias branch

[David Overton]

On Tue, May 04, 1999 at 05:30:27PM EST, Simon Taylor wrote:
> Hi,
> 
> > This looks like debugging code that has been left in.  Do you still
> > need it there?  If so, please mention it in the log message,
> > otherwise, remove it.
> 
> It's been removed.
> 
> > [...]
> > >  		InputArgModes, MagicOutputModes) },
> > > @@ -1023,35 +1039,40 @@
> > >  	%
> > >  	% Compute a goal_info for the call.
> > >  	%
> > > -	{ goal_list_instmap_delta(Goals, Delta0) },
> > >  	{ set__list_to_set(SuppArgs, SuppArgSet) },
> > > -	{ instmap_delta_restrict(Delta0, SuppArgSet, Delta) },
> > > +	{ instmap_delta_init_reachable(Delta) },
> > >  	{ goal_info_init(SuppArgSet, Delta, nondet, GoalInfo) },
> > > +	{ conj_list_to_goal(Goals, GoalInfo, ConjGoal) },
> > > +	{ list__length(SuppArgs, NumArgs) },
> > > +	{ list__duplicate(NumArgs, live, IsLives) },
> > 
> > Shouldn't IsLives be obtained from `proc_info_arglives'?
> 
> There isn't a proc_info for the new procedure at that point,
> so it could be difficult to produce anything more accurate.
> It may be worth copying the is_live value from the original proc_info
> for arguments of the sub-goal which are also arguments of the procedure.
> It really doesn't make much difference. The new procedure is assumed to
> be nondet, so uniqueness isn't really important.
> 
Ok, fair enough.  I'm happy for you to submit this now.

David
-- 
David Overton           Department of Computer Science & Software Engineering
MEngSc Student          The University of Melbourne, Australia
+61 3 9344 9159         http://www.cs.mu.oz.au/~dmo
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------