[m-dev.] For review: Enable by default the use of the external debugger

[Fergus Henderson]

On 09-Mar-1999, Erwan Jahier <Erwan.Jahier at irisa.fr> wrote:
> Estimated hours taken: 5
> 
> Enable by default the use of the external debugger on architectures that support

Please keep the log messages < 80 columns ;-)

> configure.in:
> bindist/bindist.configure.in:
> 	Define MR_USE_EXTERNAL_DEBUGGER for systems that support sockets.
> 
> 	Pass down EXTRA_CFLAGS and EXTRA_MLFLAGS the name of the socket
> 	library that may varies from one system to another.

EXTRA_CFLAGS and EXTRA_MLFLAGS are reserved for the user to override on
the command line.  So you should not use them.  Otherwise users will be
mystified as to why `mmake EXTRA_CFLAGS=-g EXTRA_MLFLAGS=--no-strip'
causes link errors.

Similarly, CFLAGS and MLFLAGS are reserved for the user to define in 
their Mmakefile.  So shouldn't use them either.

I'm not sure off-hand what the best solution is, but using EXTRA_MLFLAGS
is definitely wrong.

> runtime/mercury_conf.h.in:
> runtime/mercury_conf_param.h:
> 	

What changed there?

> +AC_MSG_CHECKING(whether we can use sockets (for Opium-M))
...
> +case "$host" in
...
> +	*)
> +		AC_MSG_RESULT(no)
> +		;;

That should probably be something
like "AC_MSG_RESULT(unknown sytem, assuming no)".

> +++ mercury_conf.h.in	1999/03/09 10:12:09
> @@ -239,6 +239,15 @@
>  */
>  #undef MR_CAN_DO_PENDING_IO
>  
> +/*
> +** MR_USE_EXTERNAL_DEBUGGER:
> +**	Allow MR_trace() to use an external process debugger
> +**	(with communication done via a socket interface)
> +**	rather than using the debugger that is part of
> +**	the Mercury runtime.
> +*/
> +#undef  MR_USE_EXTERNAL_DEBUGGER

I suggest adding "This requires that the system support sockets.
See trace/mercury_trace_external.c."

You should also change the comment at the top of mercury_trace_external.c,
where it says "disabled by default" and "should use autoconf",
since this change makes that comment obsolete.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.