[m-dev.] diff: test cases for accumulator introduction.

Fergus Henderson fjh at cs.mu.OZ.AU
Thu Jun 17 01:24:07 AEST 1999


On 16-Jun-1999, Peter Ross <petdr at cs.mu.OZ.AU> wrote:
> Index: Mmakefile
...
> +MCFLAGS = -d39  --introduce-accumulators --optimize-constructor-last-call

You should use the symbolic name `-daccumulators' (or whatever it is --
check the source code for mercury_compile.m to find out) rather than
hard-coding the number 39, because the stage numbers might change if
we introduce new stages.

It would be helpful to document why the --optimize-constructor-last-call
option is needed.

> +++ README	Wed Jun 16 15:59:06 1999
> @@ -0,0 +1,4 @@
> +The file INTRODUCED contains the procedures which should have an
> +accumulator introduced for them, when the following options are set
> +
> +        --introduce-accumulators --optimize-constructor-last-call

I suggest s/are set/are set:/
                           ^

Otherwise, that all looks great.

It might be useful to include a test case or two to test accumulator
introduction in semidet and nondet predicates. 

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------



More information about the developers mailing list