[m-dev.] for review: Aditi updates[5]

[Fergus Henderson]

On 05-Jun-1999, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> Index: compiler/typecheck.m
> ===================================================================
> RCS file: /home/staff/zs/imp/mercury/compiler/typecheck.m,v
> retrieving revision 1.258
> diff -u -u -r1.258 typecheck.m
> --- typecheck.m	1999/03/26 11:15:45	1.258
> +++ typecheck.m	1999/06/02 23:36:59
> @@ -132,7 +132,13 @@
>  :- pred typecheck__resolve_pred_overloading(module_info, list(prog_var),
>  		map(prog_var, type), tvarset, sym_name, sym_name, pred_id).
>  :- mode typecheck__resolve_pred_overloading(in, in, in, in,
> -			in, out, out) is det.
> +		in, out, out) is det.
> +
> +:- pred typecheck__resolve_pred_overloading_2(module_info,
> +		pred(module_info, list(pred_id), list(pred_id)),
> +		list(type), tvarset, sym_name, sym_name, pred_id).
> +:- mode typecheck__resolve_pred_overloading_2(in, pred(in, in, out) is det,
> +		in, in, in, out, out) is det.

Hmm, it's not really good style to export a `_2' version of a predicate.
This predicate is not well named or documented, IMHO.
You should definitely document the meaning of this predicate and
its arguments.

[...to be continued...]

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------