[m-dev.] for review: accumulator introduction

[Peter Ross]

On 15-Jun-1999, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> On 15-Jun-1999, Peter Ross <petdr at cs.mu.OZ.AU> wrote:
> > On 04-Jun-1999, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> > > On 04-Jun-1999, Peter Ross <petdr at cs.mu.OZ.AU> wrote:
> > > > +++ accumulator.m	Fri Jun  4 13:57:40 1999
> > > > +% The transformation is described more fully in papers/tail_recursive.
> > > 
> > > That reference will be meaningless to people not in the Mercury group.
> > > Please give a more detailed reference (e.g. a URL).
> 
> Don't forget that one.
> 
Done.

> > > > Index: util/mdemangle.c
> > > > -	if (category == LAMBDA || category == DEFORESTATION) {
> > > > +	if (category == LAMBDA || category == DEFORESTATION || 
> > > > +			category == ACCUMULATOR) {
> > > 
> > > The { should be on a new line.
> >
> > I can do this, but it will be inconsistent with the formatting of the
> > rest of the code.
> > 
> > Are you sure that you want this change?
> 
> Yes.  See
> <http://www.cs.mu.oz.au/mercury/information/developers/c_coding_standard.html>,
> section 5.2.1:
> 
>  | 	/*
>  | 	** if the condition is so long that the open curly doesn't
>  | 	** fit on the same line as the `if', put it on a line of
>  | 	** its own
>  | 	*/
>  | 	if (a_very_long_condition() &&
>  | 		another_long_condition_that_forces_a_line_wrap())
>  | 	{
>  | 		/* ... */
>  | 	}
> 
> If there are any other occurrences of `if' statements which do not
> fit on one line and do not have the `{' on a line of its own, then
> they should be fixed too.
> 
OK.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------