[m-dev.] Re: for review: removing --args simple

[Lee Naish]

Zoltan Somogyi <zs at cs.mu.OZ.AU> writes:

> > > -	count_output = framevar(3);
> > > -	time_output = MR_get_user_cpu_miliseconds() - framevar(4);
> > > +	r1 = framevar(3);
> > > +	r2 = MR_get_user_cpu_miliseconds() - framevar(4);
> > >  	succeed_discard();
> > 
> > I think these changes (and similar changes throughout the library
> > and runtime) make the code less readable.

>I thought about that. You are right, replacing symbolic names with
>register numbers reduces readability. However, since we are using the
>same registers for both input and output, anyone who maintains such code
>*must* be aware of the need not to overwrite registers containing inputs

How about using r1__count_output etc?  Its a bit more in-your-face than a
comment.

	lee
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------