[m-dev.] for review: dependency restructuring change #3

[Simon Taylor]

> Estimated hours taken: 4
> 
> Some more changes to minimize the complexity of the intermodule dependencies. 
> In particular, ensure that hlds_module.m does not need to import llds.m.
 

> Index: compiler/mercury_compile.m
> ===================================================================

> @@ -1053,28 +1054,31 @@
>  
>  %-----------------------------------------------------------------------------%
>  
> -:- pred mercury_compile__backend_pass(module_info, module_info,
> +:- pred mercury_compile__backend_pass(module_info, module_info, global_data,
>  	list(c_procedure), io__state, io__state).
> -% :- mode mercury_compile__backend_pass(di, uo, out, di, uo) is det.
> -:- mode mercury_compile__backend_pass(in, out, out, di, uo) is det.
> +% :- mode mercury_compile__backend_pass(di, uo, out, out, di, uo) is det.
> +:- mode mercury_compile__backend_pass(in, out, out, out, di, uo) is det.

I'd suggest removing the commented out mode declarations in mercury_compile.m
rather than maintaining them. When we do add unique modes for module_infos,
it's unlikely that the entire module_info will have inst `unique' as these
mode declarations suggest.

Otherwise this change looks fine.

Simon.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------