[m-dev.] Fix a bug caused by one of my recent changes

Fergus Henderson fjh at cs.mu.OZ.AU
Tue Feb 23 06:30:30 AEDT 1999


On 22-Feb-1999, Erwan Jahier <Erwan.Jahier at irisa.fr> wrote:
> +++ mercury_stack_trace.h	1999/02/22 19:20:52
> @@ -137,5 +137,29 @@
...
> +/*
> +** MR_print_proc_id prints an identification of the given procedure,
> +** consisting of "pred" or "func", module name, pred or func name, arity,
> +** mode number and determinism, followed by an optional extra string,
> +** and a newline.
> +**
> +** If the procedure has trace layout information and the relevant one of
> +** base_sp and base_curfr is not NULL, it also prints the call event number,
> +** call sequence number and call depth of the call.
> +*/
> +
> +void	MR_print_proc_id(FILE *fp, const MR_Stack_Layout_Entry *entry,
> +			const char *extra, Word *base_sp, Word *base_curfr);
> +void	MR_dump_stack_record_print(FILE *fp, 
> +			const MR_Stack_Layout_Entry *entry_layout, int count, 
> +			int start_level, Word *base_sp, Word *base_curfr);

The blank line should be between the two declarations, not between
the first declaration and its associated comment.

You should document MR_dump_stack_record_print() --
now that it is exported, it needs documentation.

Apart from that, this change looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "Binaries may die
WWW: <http://www.cs.mu.oz.au/~fjh>  |   but source code lives forever"
PGP: finger fjh at 128.250.37.3        |     -- leaked Microsoft memo.



More information about the developers mailing list