[m-dev.] For review: Add a pred_or_func attribute to the external debugger

Fergus Henderson fjh at cs.mu.OZ.AU
Sat Feb 20 01:57:26 AEDT 1999


On 19-Feb-1999, Erwan Jahier <Erwan.Jahier at irisa.fr> wrote:
> |
> +++ fixbug1.5(w)/browser/debugger_interface.m Fri, 19 Feb 1999 15:28:40 +0100 jahier (submitdiff/6_debugger_i 1.7 640)
> @@ -63,6 +63,9 @@
>  
>  :- type goal_path_string == string.
>  
> +:- type pred_or_func
> +	--->	predicate
> +	;	function.

I suggest adding the following comment just before that type definition:

% This enumeration must be EXACTLY the same as the MR_PredFunc enum in
% runtime/mercury_stack_layout.h, and in the same order, since the code
% assumes the representation is the same.

Likewise, you should add a similar comment in runtime/mercury_stack_layout.h.

Apart from that, that change looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "Binaries may die
WWW: <http://www.cs.mu.oz.au/~fjh>  |   but source code lives forever"
PGP: finger fjh at 128.250.37.3        |     -- leaked Microsoft memo.



More information about the developers mailing list