[m-dev.] Re: your mail

[Fergus Henderson]

On 10-Feb-1999, Erwan Jahier <Erwan.Jahier at irisa.fr> wrote:
> +				if (message == NULL)
> +				{

The `{' should be on the same line as the `if'.

> +				} else {
> +					MR_send_message_to_socket_format(
> +						"\"error(%s)\".\n", message);
> +				}

I think the quotes are in the wrong place there.
You want to send `error("...")' rather than
`"error(...)"', don't you?

So I think it should be

					MR_send_message_to_socket_format(
						"error(\"%s\").\n", message);

> -			MR_trace_retry(layout, saved_regs, event_details,
> +			message = MR_trace_retry(layout, saved_regs, event_details,
>  				seqno, depth, max_mr_num, jumpaddr);
> +			fflush(MR_mdb_out);
> +			fprintf(MR_mdb_err, message);
> +			fprintf(MR_mdb_err, "\n");

That should be

			fprintf(MR_mdb_err, "%s\n", message);

Otherwise you will run into problems if the message
contains a "%".

Apart from those things, your change looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "Binaries may die
WWW: <http://www.cs.mu.oz.au/~fjh>  |   but source code lives forever"
PGP: finger fjh at 128.250.37.3        |     -- leaked Microsoft memo.