[m-dev.] For review: make things work with -DUSE_EXTERNAL_DEBUGGER

Fergus Henderson fjh at cs.mu.OZ.AU
Thu Feb 4 21:27:16 AEDT 1999


On 04-Feb-1999, Erwan Jahier <Erwan.Jahier at irisa.fr> wrote:
> | >  #ifdef MR_USE_EXTERNAL_DEBUGGER
> | >  	if (MR_trace_handler == MR_TRACE_EXTERNAL)
> | > -		MR_trace_init_external(); /* should be in this module */
> | > +		MR_trace_init_external();
> | >  #endif
> | >  }
> | >  
> | > @@ -168,7 +168,7 @@
> | >  {
> | >  #ifdef MR_USE_EXTERNAL_DEBUGGER
> | >  	if (MR_trace_handler == MR_TRACE_EXTERNAL)
> | > -		MR_trace_final_external(); /* should be in this module */
> | > +		MR_trace_final_external();
> | >  #endif
> | >  }
> | 
> | I think they need to be changed to indirect calls.
> 
> OK.
> 
> (both are working; did I miss some warnings?)

Yes, normally you would get a warning when linking runtime/libmer_rt.so
if it contained undefined references.

Anyway your change looks fine now, thanks.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "Binaries may die
WWW: <http://www.cs.mu.oz.au/~fjh>  |   but source code lives forever"
PGP: finger fjh at 128.250.37.3        |     -- leaked Microsoft memo.



More information about the developers mailing list