[m-dev.] for review: MR_int_leastN_t, and remove refs to old macros

Fergus Henderson fjh at cs.mu.OZ.AU
Tue Aug 17 20:42:34 AEST 1999


On 17-Aug-1999, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> 
> Use our own MR_ prefixed variants of int_leastN_t, and ensure that
> the system compiles and bootstraps with all but the most recent parts
> of mercury_bootstrap.h being disabled.
...
> BTW, I can commit the changes relating to MR_int_leastN_T separately
> if anyone insists.

I think that would be a good idea.

> Index: runtime/mercury_types.h
> ===================================================================
> RCS file: /home/mercury1/repository/mercury/runtime/mercury_types.h,v
> retrieving revision 1.17
> diff -u -b -r1.17 mercury_types.h
> --- mercury_types.h	1999/05/31 18:25:28	1.17
> +++ mercury_types.h	1999/06/10 04:20:40
> @@ -22,45 +22,38 @@
>  #include "mercury_conf.h"
>  
>  /*
> +** This section defines type similar to C9X's <stdint.h> header.

s/type/types/

> +** We do not use this header file, or the <inttypes.h> or <sys/types.h> files

s/this header file/<stdint.h>/
(Otherwise it is ambiguous; I thought for a while that you meant
mercury_types.h.)

> +** that substitute for it on some systems because (a) some such files
> +** do not define the types we need, and (b) some such files include
> +** things that conflict with our desire to reserve some real machine registers
> +** for Mercury abstract machine registers.

I suggest s/things that/inline function definitions, which/
and appending ", since global register variable declarations must
precede all function definitions".

Apart from that, this change looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------



More information about the developers mailing list