[m-dev.] for review: rename tag varieties and simple vectors.

[Fergus Henderson]

On 19-Apr-1999, Tyson Dowd <trd at cs.mu.OZ.AU> wrote:
> This change does some renaming to meet the new nomenclature introduced
> in the RTTI paper.

I think that rationale should go in the log message.

s/meet/match/ ?

> Rename simple tags as unshared tags, complicated tags as shared
> remote tags and complicated constant tags as shared local.
> Also rename "simple vector" as "functor descriptor",
> "functors vector" as "enum vector".
...
> Index: compiler/hlds_data.m
> ===================================================================
> RCS file: /home/mercury1/repository/mercury/compiler/hlds_data.m,v
> retrieving revision 1.33
> diff -u -r1.33 hlds_data.m
> --- hlds_data.m	1999/04/08 08:41:04	1.33
> +++ hlds_data.m	1999/04/14 05:41:02
> @@ -280,23 +280,27 @@
>  			% represented as global data. The word just contains
>  			% the address of the tabling pointer of the
>  			% specified procedure.
> -	;	simple_tag(tag_bits)
> -			% This is for constants or functors which only
> -			% require a simple tag.  (A "simple" tag is one
> -			% which fits on the bottom of a pointer - i.e.
> -			% two bits for 32-bit architectures, or three bits
> -			% for 64-bit architectures).
> +	;	unshared_tag(tag_bits)
> +			% This is for constants or functors which can be
> +			% distinguished with just a primary tag.
> +			% An "unshared" tag is one which fits on the
> +			% bottom of a pointer - i.e.  two bits for
> +			% 32-bit architectures, or three bits for 64-bit
> +			% architectures, and is used for just one
> +			% functor).

You have an unmatched ')' here.  Also the final phrase "and is used for
just one functor" gets a bit lost.  I suggest the following changes:

	s/- i.e./(i.e./
	s/architectures,/architectures)/
	s/functor)/functor/

> +++ std_util.m	1999/04/19 05:18:01
>                  /* 
> -                 * Look past the secondary tag, and get the simple vector,
> -                 * then we can just use the code for simple tags.
> +                 * Look past the secondary tag, and get the functor 
> +		 * descriptor, then we can just use the code for
> +		 * unshared tags.
>                   */

Hmm, inconsistent use of tabs and spaces.
(Also the comment uses a non-standard style.)

Apart from the above comments, this change looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------