[m-dev.] for review: introduction of two new directories

Fergus Henderson fjh at cs.mu.OZ.AU
Thu Sep 24 17:15:16 AEST 1998


On 24-Sep-1998, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> 
> > > The introduction of two new directories, each containing a new library,
> > > requires significant changes to the Mmakefiles in the various directories.
> > > I think it would be a good idea for these changes to be reviewed by Fergus
> > > and Tyson independently of the other changes in my next commit.
> > 
> > How about a log message?
> 
> The quotes text above has the same information as the log message for
> these changes would anyway.

One reason for posting the log message is so that the reviewers can
review the log message, for example checking that it contains appropriate
rationale for the changes.  The above quoted text does not contain
any rationale for the change.

> Fergus, I thought you knew at least some of these arguments.

Yes, but you should put the arguments in the log message anyway,
for the benefit of future maintainers.

> When I proposed adding two new directories in an earlier mail, you agreed.

I think you are mistaken.
I don't recall you proposing to add two new directories before.

Here's the text I think you are thinking of:

 | > One solution is to move some of the debugger stuff out of the runtime
 | > and into a separate library that depends on the standard library.
 | 
 | That would be a fine solution too.

This only mentions one new directory.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.



More information about the developers mailing list