[m-dev.] Re: for review: term browser (version one) (revised diff -u!)

[Fergus Henderson]

On 23-Oct-1998, Bert THOMPSON <aet at cs.mu.OZ.AU> wrote:
> -	% XXX: hardwired constant 10 in help.
>  :- pred help(io__state::di, io__state::uo) is det.
...
>  \t< [n]          -- set depth (default is 10)\n\

That XXX should stay, since you didn't un-hardwire it.

>  :- mode run_command(in, in, out, di, uo) is det.
>  run_command(Command, State, NewState) -->
>  	( { Command = unknown } ->
> -		io__write_string("error: unknown command. try \"help\"\n"),
> +		io__write_string("error: Try \"help\".\n"),

That change is not an improvement.  s/error/Error/ and s/Try/try/.
Also the "unknown command" part was useful.

I think the message should be

	Error: unknown command.
	Type "help" for help.

Also, the interface to the `browse' module is still not quite right.
But we can fix that later when we connect the browser to the debugger.
Apart from that, it looks fine, so I'm happy for you to commit it once
you've fixed those two things mentioned above.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.